Patch for mem2reg pass

Piotr Perek pperek1234 at gmail.com
Fri Jul 19 10:09:23 PDT 2013


Hi David,

On 17.07.2013 20:38, David Blaikie wrote:
> Sorry for the lack of details - you should be able to reproduce the
> bug that caused me to add the conditional fix (the "if this thing is
> in the map then do stuff" bit that wasn't in your original patch) by
> applying your original patch (without my fix) and having compiler-rt
> checked out beneath llvm/projects then running "make check-all" or the
> equivalent target for your build system. This will build LLVM and
> Clang, then using the just-built Clang it'll build compiler-rt (this
> is where you'll see the crash) and if that passes, it'll run the LLVM,
> Clang, and Compiler-rt lit tests.
>
> So what I'm hoping is you can reproduce the failure that lead to my
> fix, reduce a test case so you can demonstrate that failure using the
> llvm lit tests rather than using the compiler-rt build, then run the
> same command (make check-all) again & hit the second issue that I
> didn't get around to fixing yet, reduce a test case for that and fix
> the issue... and if you're lucky, at that point you should be able to
> get a "make check-all" to pass (unless there are other hidden issues
> yet to be revealed).
>
> At that point you might want to try a self-host. Build Clang, then
> build Clang with that Clang.
>
>> Best regards,
>> Piotr

Thank you for your detailed answer. I was able to reproduce failures 
that you found. I corrected this bugs and prepared additional test 
files. Please take a look.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mem2reg_2013_07_19.diff
Type: text/x-diff
Size: 18837 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130719/12823b5c/attachment.diff>


More information about the llvm-commits mailing list