[llvm] r186503 - llvm-ar: doExtract(): Write extracted files with F_Binary. It should fix llvm/test/Object/extract.ll

[Rafael Avila de Espindola]

Thanks. I now managed to fix my msvc setup (was missing gnuwin32), so I should be able to better test on windows now.

Sent from my iPhone

On 2013-07-17, at 8:31, NAKAMURA Takumi <geek4civic at gmail.com> wrote:

> Author: chapuni
> Date: Wed Jul 17 07:31:50 2013
> New Revision: 186503
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=186503&view=rev
> Log:
> llvm-ar: doExtract(): Write extracted files with F_Binary. It should fix llvm/test/Object/extract.ll
> 
> Modified:
>    llvm/trunk/tools/llvm-ar/llvm-ar.cpp
> 
> Modified: llvm/trunk/tools/llvm-ar/llvm-ar.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-ar/llvm-ar.cpp?rev=186503&r1=186502&r2=186503&view=diff
> ==============================================================================
> --- llvm/trunk/tools/llvm-ar/llvm-ar.cpp (original)
> +++ llvm/trunk/tools/llvm-ar/llvm-ar.cpp Wed Jul 17 07:31:50 2013
> @@ -304,7 +304,7 @@ static void doExtract(StringRef Name, ob
> 
>   int FD;
>   failIfError(
> -      sys::fs::openFileForWrite(Storage.c_str(), FD, sys::fs::F_None, Mode),
> +      sys::fs::openFileForWrite(Storage.c_str(), FD, sys::fs::F_Binary, Mode),
>       Storage.c_str());
> 
>   {
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits