[llvm] r186489 - Fix ARMFastISel::ARMEmitIntExt shift emission

JF Bastien jfb at google.com
Wed Jul 17 08:21:36 PDT 2013


> I forgot to say earlier, but can you add a test case?

I don't see much code tested this way, but I guess it's simple enough:

diff --git a/test/CodeGen/ARM/fast-isel-ext.ll
b/test/CodeGen/ARM/fast-isel-ext.ll
index 15d0d3c..6d7d1f4 100644
--- a/test/CodeGen/ARM/fast-isel-ext.ll
+++ b/test/CodeGen/ARM/fast-isel-ext.ll
@@ -6,6 +6,15 @@
 ; RUN: llc < %s -O0 -fast-isel-abort -mtriple=armv5-linux-gnueabi |
FileCheck %s --check-prefix=prev6
 ; RUN: llc < %s -O0 -fast-isel-abort -mtriple=thumbv7-apple-ios |
FileCheck %s --check-prefix=v7

+; Also test direct-to-object and objdump.
+; RUN: llc < %s -filetype=obj -O0 -fast-isel-abort
-mtriple=armv7-apple-ios | llvm-objdump -disassemble -triple
armv7-apple-ios - | FileCheck %s --check-prefix=v7
+; RUN: llc < %s -filetype=obj -O0 -fast-isel-abort
-mtriple=armv7-linux-gnueabi | llvm-objdump -disassemble -triple
armv7-linux-gnueabi - | FileCheck %s --check-prefix=v7
+; RUN: llc < %s -filetype=obj -O0 -fast-isel-abort
-mtriple=armv4t-apple-ios | llvm-objdump -disassemble -triple
armv4t-apple-ios - | FileCheck %s --check-prefix=prev6
+; RUN: llc < %s -filetype=obj -O0 -fast-isel-abort
-mtriple=armv4t-linux-gnueabi | llvm-objdump -disassemble -triple
armv4t-linux-gnueabi - | FileCheck %s --check-prefix=prev6
+; RUN: llc < %s -filetype=obj -O0 -fast-isel-abort
-mtriple=armv5-apple-ios | llvm-objdump -disassemble -triple
armv5-apple-ios - | FileCheck %s --check-prefix=prev6
+; RUN: llc < %s -filetype=obj -O0 -fast-isel-abort
-mtriple=armv5-linux-gnueabi | llvm-objdump -disassemble -triple
armv5-linux-gnueabi - | FileCheck %s --check-prefix=prev6
+; RUN: llc < %s -filetype=obj -O0 -fast-isel-abort
-mtriple=thumbv7-apple-ios | llvm-objdump -disassemble -triple
thumbv7-apple-ios - | FileCheck %s --check-prefix=v7
+
 ; Can't test pre-ARMv6 Thumb because ARM FastISel currently only supports
 ; Thumb2. The ARMFastISel::ARMEmitIntExt code should work for Thumb by always
 ; using two shifts.



More information about the llvm-commits mailing list