[llvm] r186469 - llvm/test/Object/ar-create.test: Relax a CHECK line to satisfy localized message catalogue.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Jul 16 21:39:43 PDT 2013


On 17 July 2013 00:20, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> It could be done to tweak dwLanguageId on FormatMessage(), in
> Windows/system_error.inc.
>
>     MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), // Default language
>
> Could we settle language/locale to us English here?
> FYI, the buildslave uses codepage 65001.

But then users in another language would get error messages in
English, no? Right now the vast majority of llvm own messages are
always in English, so that might be a short term improvement, but in
the end we should probably keep the door open for supporting
internationalization.

I asked for something like the LANG environment variable so  that we
could test for the error having something to do with trying to use a
directory as a file but still use the system language in regular
usage. If that is not possible, that is fine. We just get a tiny bit
less test coverage.

Thanks,
Rafael



More information about the llvm-commits mailing list