[llvm] r186374 - Fix TimeValue::toWin32Time() to be symmetric to fromWin32Time() and compatible to Win32's FILETIME.

[Aaron Ballman]

On Tue, Jul 16, 2013 at 8:31 AM, Aaron Ballman <aaron at aaronballman.com> wrote:
> On Mon, Jul 15, 2013 at 10:43 PM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>> Author: chapuni
>> Date: Mon Jul 15 21:43:51 2013
>> New Revision: 186374
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=186374&view=rev
>> Log:
>> Fix TimeValue::toWin32Time() to be symmetric to fromWin32Time() and compatible to Win32's FILETIME.
>>
>> llvm-ar is the only user of toWin32Time() (via setLastModificationAndAccessTime), and r186298 can be reverted.
>> It had been buggy since the initial commit.
>>
>> FIXME: Could we rename {from|to}Win32Time as {from|to}Win32FILETIME in TimeValue?
>
> I'd be fine with renaming it to FILETIME (I'd kind of prefer it, actually).
>
> Can we also see a unit test for this since it should trivially round trip?

Hah!  And then I saw r186375.  Thanks!  ;-)

~Aaron