[lld] r185657 - Don't pass llvm::errs() all over the place. Diagnostics always go to stderr.

[Rafael Espíndola]

Sure, r186366.

On 15 July 2013 19:30, Nick Kledzik <kledzik at apple.com> wrote:
> Rafael,
>
> Can you revert this change.  I want to check in a change that builds and runs the unittests as part of lld-test.  So the unittests are built and run by everyone including the build bots.
>
> -Nick
>
>
> On Jul 5, 2013, at 3:48 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>>> There are unittests in lld that run invoke the Drivers with raw_string_ostreams and parse the string to check that the correct error was generated.  This change breaks those tests.
>>>
>>> I just recently noticed that those unittests are not being built and run as part of the lld-test target.  I’m still trying to figure out why.
>>
>> OK, if we need these tests, then we should revert this, but may I ask
>> what is wrong with with pipes + FileCheck? That is how we test every
>> error other than clang's -verify support.
>