[llvm] r186240 - Try to open the file before use data from stat.

Rafael Espindola rafael.espindola at gmail.com
Fri Jul 12 22:07:22 PDT 2013


Author: rafael
Date: Sat Jul 13 00:07:22 2013
New Revision: 186240

URL: http://llvm.org/viewvc/llvm-project?rev=186240&view=rev
Log:
Try to open the file before use data from stat.

Looks like on mingw we get bogus last modification times on directories.
Should fix the mingw bots.

Modified:
    llvm/trunk/tools/llvm-ar/llvm-ar.cpp

Modified: llvm/trunk/tools/llvm-ar/llvm-ar.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-ar/llvm-ar.cpp?rev=186240&r1=186239&r2=186240&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-ar/llvm-ar.cpp (original)
+++ llvm/trunk/tools/llvm-ar/llvm-ar.cpp Sat Jul 13 00:07:22 2013
@@ -560,6 +560,9 @@ static void performWriteOperation(Archiv
       sys::fs::file_status Status;
       failIfError(sys::fs::status(FileName, Status), FileName);
 
+      OwningPtr<MemoryBuffer> File;
+      failIfError(MemoryBuffer::getFile(FileName, File), FileName);
+
       uint64_t secondsSinceEpoch =
           Status.getLastModificationTime().toEpochTime();
       printWithSpacePadding(Out, secondsSinceEpoch, 12);
@@ -570,8 +573,6 @@ static void performWriteOperation(Archiv
       printWithSpacePadding(Out, Status.getSize(), 10);
       Out << "`\n";
 
-      OwningPtr<MemoryBuffer> File;
-      failIfError(MemoryBuffer::getFile(FileName, File), FileName);
       Out << File->getBuffer();
     } else {
       object::Archive::child_iterator OldMember = I->getOld();





More information about the llvm-commits mailing list