[llvm] r186232 - Revert commit r186216 -- it's breaking bots:

Chandler Carruth chandlerc at gmail.com
Fri Jul 12 17:42:57 PDT 2013


Author: chandlerc
Date: Fri Jul 12 19:42:56 2013
New Revision: 186232

URL: http://llvm.org/viewvc/llvm-project?rev=186232&view=rev
Log:
Revert commit r186216 -- it's breaking bots:

  http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/6897/steps/check-all/logs/LLVM%3A%3Aarchive-format.test

Original commit log:
  Fix a off by one error about which members need to use the string
  table.

Removed:
    llvm/trunk/test/Object/archive-format.test
Modified:
    llvm/trunk/tools/llvm-ar/llvm-ar.cpp

Removed: llvm/trunk/test/Object/archive-format.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/archive-format.test?rev=186231&view=auto
==============================================================================
--- llvm/trunk/test/Object/archive-format.test (original)
+++ llvm/trunk/test/Object/archive-format.test (removed)
@@ -1,22 +0,0 @@
-Test the exact archive format. In particular, test which file names use the
-string table or not.
-
-REQUIRES: shell
-
-RUN: mkdir -p %t
-RUN: cd %t
-
-RUN: echo bar > 0123456789abcde
-RUN: echo zed > 0123456789abcdef
-
-RUN: rm -f test.a
-RUN: llvm-ar rc test.a 0123456789abcde 0123456789abcdef
-RUN: cat test.a | FileCheck -strict-whitespace %s
-
-CHECK:      !<arch>
-CHECK-NEXT: //                                              18        `
-CHECK-NEXT: 0123456789abcdef/
-CHECK-NEXT: 0123456789abcde/{{.*}}  1000  1000  100664  4         `
-CHECK-NEXT: bar
-CHECK-NEXT: /0              {{.*}}  1000  1000  100664  4         `
-CHECK-NEXT: zed

Modified: llvm/trunk/tools/llvm-ar/llvm-ar.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-ar/llvm-ar.cpp?rev=186232&r1=186231&r2=186232&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-ar/llvm-ar.cpp (original)
+++ llvm/trunk/tools/llvm-ar/llvm-ar.cpp Fri Jul 12 19:42:56 2013
@@ -419,7 +419,7 @@ StringRef NewArchiveIterator::getNew() c
 template <typename T>
 void addMember(std::vector<NewArchiveIterator> &Members,
                std::string &StringTable, T I, StringRef Name) {
-  if (Name.size() < 16) {
+  if (Name.size() < 15) {
     NewArchiveIterator NI(I, Twine(Name) + "/");
     Members.push_back(NI);
   } else {





More information about the llvm-commits mailing list