[PATCH] EABI Divmod, take #1

Anton Korobeynikov anton at korobeynikov.info
Wed Jul 10 23:41:59 PDT 2013


Hi Renato,

The following:

+  bool isTargetEABI() const {
+    return TargetTriple.getEnvironment() == Triple::EABI;
+  }

Looks a bit misleading. After all - gnueabi is eabi as well, but with
just some additional stuff... Maybe it's possible to change the name
somehow?


On Thu, Jul 11, 2013 at 5:41 AM, Renato Golin <renato.golin at linaro.org> wrote:
> Hi all,
>
> The attached patch implements __eabi_*divmod calls when on EABI mode only.
> It also allows for the contraction of div+mod and uses the correct ABI of
> using R1, not the stack as in the GNU variant.
>
> This patch does not test for 64-bit values correctness, yet, nor the use of
> divmod for calculating only the remainder, which shall go on separate
> patch(es). FIXMEs in place.
>
> The test-suite buildbot is unaffected because it runs on
> arm-linux-gnueabihf, not arm-none-eabi.
>
> Please review.
>
> cheers,
> --renato
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University



More information about the llvm-commits mailing list