TableGen generates an enum to name Schedule Model

[Jakob Stoklund Olesen]

On Jul 9, 2013, at 7:05 AM, Vincent Lejeune <vljn at ovi.com> wrote:

>> On Jul 8, 2013, at 6:02 PM, Sean Silva <silvas at purdue.edu> wrote:
>> 
>>>   Three tiny nits:
>>> 
>>>   +Instructions Itinerary can be queried using MCDesc::getSchedClass() ; the 
>> value
>>>   +can be named by an enum generated by Tablegen in the namespace XXXSCHED ;
>>>   +the name of the schedule classes are the same as provided in 
>> XXXSchedule.td plus
>>>   +a default NoIntinerary class.
>>> 
>>>   These semicolons should be periods. Also, please capitalize the 
>> "g" in TableGen. Also, I think you mean "Instruction 
>> itineraries" and not "Instructions Itinerary”.

> +Instructions itineraries can be queried using MCDesc::getSchedClass(). the
> +value can be named by an enum generated by TableGen in XXXGenInstrInfo.inc.
> +the name of the schedule classes are the same as provided in XXXSchedule.td plus
> +a default NoIntinerary class.
> +You will need to include XXXGenInstrInfo.inc after defining
> +GET_INSTRINFO_OPERAND_ENUM (see above). R600 provides an example of such
> +query :

Vincent, code reviews are not ed scripts. When Sean asked you to use periods between your sentences, it is fairly safe to assume that he also meant for you to capitalize the first word of sentences.

Your reference to GET_INSTRINFO_OPERAND_ENUM is also no longer relevant.

Please respect reviewers’ time. This is just sloppy.

Thanks,
/jakob