IfConversion non-recursive patch

[Hal Finkel]

----- Original Message -----
> 
> 
> Hi all.
> 
> 
> I want to propose patch for making IfConversion analyze algorithm
> non-recursive.
> 
> 
> Recursive algorithm causes running out of stack space on our system
> on huge functions (with many BasicBlocks).
> 
> 
> 
> Could anyone review and apply it?

This seems like a good idea; to be clear, this is functionally identical to the current version?

Superficially, I have two comments:

1. There are some lines > 80 characters. Please wrap these.

2. I think that we prefer to put utility classes into an anonymous namespace, and so if you move AnalyzeUnRecursive into an anonymous namespace that will make it more consistent with the rest of the code. Also, I'm not sure sure that we need to put 'UnRecursive' in the name (although I don't have a better suggestion at the moment).

Thanks,
Hal

> 
> --
> Best regards, Andrew Zhogin
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory