[PATCH] Introduce a GlobalList ctor which takes a MemoryBuffer to make it more unit testable, and fix memory leak in the other ctor.

Peter Collingbourne peter at pcc.me.uk
Mon Jul 8 15:38:40 PDT 2013



================
Comment at: include/llvm/Transforms/Utils/GlobalList.h:46
@@ -44,1 +45,3 @@
   GlobalList(const StringRef Path);
+  GlobalList(MemoryBuffer *MB);
+
----------------
Alexey Samsonov wrote:
> This should be const MemoryBuffer*
Done.

================
Comment at: lib/Transforms/Utils/GlobalList.cpp:42
@@ -41,1 +41,3 @@
 
+  init(File.take());
+}
----------------
Alexey Samsonov wrote:
> Please merge D1093 here.
Done.


http://llvm-reviews.chandlerc.com/D1090

BRANCH
  globallist2

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list