[RFC, PowerPC] Always use "assembler dialect" 1

Ulrich Weigand Ulrich.Weigand at de.ibm.com
Mon Jul 8 13:01:44 PDT 2013


Hal Finkel <hfinkel at anl.gov> wrote on 08.07.2013 20:59:31:

> Of the two, I'd be in favor of adding an isDarwin field, and that
> will make it clear what is going on. However, is there a reason that
> we just can't give the printer access to the target triple somehow
> (either directly, or via a MCSubtargetInfo object, etc.)?

Ah, right, we do have a MCSubtargetInfo.  This would take care of
the InstPrinter.   For the PPCMCExpr, we can just add an explicit
isDarwin parameter and pass it in at creation (after reverting
the 184441 revision).   It ends up a bit more wordy, but overall
probably clearer ...

(See attached file: diff-llvm-asmdialect2)

Bye,
Ulrich

-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff-llvm-asmdialect2
Type: application/octet-stream
Size: 13693 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130708/b3976e0d/attachment.obj>


More information about the llvm-commits mailing list