[PATCH] cmake: Find xdot or xdot.py

Chandler Carruth chandlerc at gmail.com
Mon Jul 8 11:37:35 PDT 2013



================
Comment at: cmake/config-ix.cmake:277-281
@@ +276,7 @@
+
+if(NOT HAVE_XDOT)
+  llvm_find_program(xdot.py)
+  set(HAVE_XDOT 1 CACHE INTERNAL "Is xdot available ?")
+  set(LLVM_PATH_XDOT ${LLVM_PATH_XDOT_PY})
+endif()
+
----------------
CMake's find_program has a defined way of searching multiple names. Currently, this isn't exposed in llvm_find_program, but we should fix that instead of adding a hack here.

I would suggest first submitting a patch that makes llvm_find_program actually use the same interface as find_program, and have it merely add the requisite variable prefixes and additional HAVE_... variable styles. Then your patch will become much simpler.


http://llvm-reviews.chandlerc.com/D715



More information about the llvm-commits mailing list