r185397 - [APFloat] Ensure that we can properly parse strings that do not have null terminators.

[Michael Gottesman]

Quick typing got the better of me before. ; ).

Michael

On Jul 5, 2013, at 2:15 PM, Eli Friedman <eli.friedman at gmail.com> wrote:

> On Fri, Jul 5, 2013 at 2:07 PM, Jordan Rose <jordan_rose at apple.com> wrote:
> Just looking at this now: shouldn't the end-of-string check come before we try to read the character? 
> 
> +  if (decDigitValue(*D.firstSigDigit) >= 10U || D.firstSigDigit == str.end()) {
> 
> If the string is on the end of a page, this could still crash.
> 
> r185437.
> 
> -Eli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130705/8892a20e/attachment.html>