r185397 - [APFloat] Ensure that we can properly parse strings that do not have null terminators.

Jordan Rose jordan_rose at apple.com
Fri Jul 5 14:07:44 PDT 2013


Just looking at this now: shouldn't the end-of-string check come before we try to read the character? 

+  if (decDigitValue(*D.firstSigDigit) >= 10U || D.firstSigDigit == str.end()) {

If the string is on the end of a page, this could still crash.

Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130705/8cfe86a7/attachment.html>


More information about the llvm-commits mailing list