[PATCH] [ARMv8] Add MC assembly/disassembly for VSEL

Amaury de la Vieuville amaury.dlv at gmail.com
Thu Jul 4 08:13:40 PDT 2013



================
Comment at: lib/Target/ARM/Disassembler/ARMDisassembler.cpp:778
@@ +777,3 @@
+    Size = 4;
+    UpdateThumbVFPPredicate(MI);
+    return result;
----------------
I think this is unnecessary. As you said, these instructions are not predicable, `UpdateThumbVFPPredicate` wouldn't find any predicate to update. However that would still update the IT state despite VSEL being unpredictable inside an IT block (which is not yet enforced).




http://llvm-reviews.chandlerc.com/D1098



More information about the llvm-commits mailing list