[llvm] r185616 - FastISel can only apend to basic blocks.

Eric Christopher echristo at gmail.com
Wed Jul 3 22:04:43 PDT 2013


On Wed, Jul 3, 2013 at 9:51 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
>
> On Jul 3, 2013, at 9:47 PM, Eric Christopher <echristo at gmail.com> wrote:
>
>> On Wed, Jul 3, 2013 at 9:32 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
>>> Author: stoklund
>>> Date: Wed Jul  3 23:32:39 2013
>>> New Revision: 185616
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=185616&view=rev
>>> Log:
>>> FastISel can only apend to basic blocks.
>>>
>>
>> This seems to be worded oddly since FastISel itself goes bottom up?
>
> Right. It goes bottom up, but it can only be invoked once for a basic block.
>

Right. :) It just seemed an odd way to put it since we iterate
backwards through each block.

>>> +  // Instructions are append to FuncInfo.MBB. If the basic block already
>>
>> Also, FWIW, "appended" :)
>
> Apparently a very hard work to spell correctly ;)
>

:)

-eric



More information about the llvm-commits mailing list