[polly] r185254 - TempScop: (Partial) Implement the printDetail function.

[Tobias Grosser]

On 07/02/2013 06:34 PM, Hongbin Zheng wrote:
> Hi tobi,
>
>
> On Wed, Jul 3, 2013 at 12:21 AM, Tobias Grosser <tobias at grosser.es> wrote:
>
>> On 06/29/2013 12:00 AM, Hongbin Zheng wrote:
>>
>>> Author: ether
>>> Date: Sat Jun 29 02:00:14 2013
>>> New Revision: 185254
>>>
>>> URL: http://llvm.org/viewvc/llvm-**project?rev=185254&view=rev<http://llvm.org/viewvc/llvm-project?rev=185254&view=rev>
>>> Log:
>>> TempScop: (Partial) Implement the printDetail function.
>>>
>>
>> Thanks!
>>
>> Also, it would be nice to check the changes with clang-format before you
>> commit them.
>>
>> If clang-format is in your path, you can just run 'make
>> polly-check-format' (or 'make polly-update-format' to fix the formatting)
>>
>> Some comments inline.
>>
>> Cheers
>> Tobias
>>
>>
>>     void TempScop::printDetail(raw_**ostream &OS, ScalarEvolution *SE,
>>>                               LoopInfo *LI, const Region *CurR,
>>> -                           unsigned ind) const {}
>>> +                           unsigned ind) const {
>>> +
>>> +  // FIXME: Print other details rather than memory accesses.
>>> +  typedef Region::const_block_iterator bb_iterator;
>>> +  for (bb_iterator I = CurR->block_begin(), E = CurR->block_end(); I !=
>>> E; ++I){
>>> +    BasicBlock *CurBlock = *I;
>>> +
>>> +    AccFuncMapType::const_iterator AccSetIt = AccFuncMap.find(CurBlock);
>>> +
>>> +    // Ignore trivial blocks that do not contain any memory access.
>>> +    if (AccSetIt == AccFuncMap.end()) continue;
>>>
>>
>> It would be nice to move this into a separate function that is also used
>> in place of the Scop::isTrivialBB() function in ScopInfo.cpp.
>>
> Ok
>
>>
>> Such a patch is approved for commit. ;-)
>
> Well, this patch is reviewed before, you said once I shorten the commit
> message, it is ok to commit ;-)

Yes, I remember. I took a too long delay in reviewing your patches, so I 
forgot it for a moment.

Cheers,
Tobi