[PATCH] ARM: fix application of de morgan's law

Saleem Abdulrasool compnerd at compnerd.org
Sat Jun 29 14:53:19 PDT 2013


Hi t.p.northover,

! (EnableARMTailCalls && Subtarget->supportsTailCall()) <=>
    !EnableARMTailCalls || !Subtarget->supportsTailCall()

This would inadvertently enable tail calls when they should not be.

Signed-off-by: Saleem Abdulrasool <compnerd at compnerd.org>

http://llvm-reviews.chandlerc.com/D1069

Files:
  lib/Target/ARM/ARMISelLowering.cpp

Index: lib/Target/ARM/ARMISelLowering.cpp
===================================================================
--- lib/Target/ARM/ARMISelLowering.cpp
+++ lib/Target/ARM/ARMISelLowering.cpp
@@ -1375,7 +1375,7 @@
   bool isThisReturn   = false;
   bool isSibCall      = false;
   // Disable tail calls if they're not supported.
-  if (!EnableARMTailCalls && !Subtarget->supportsTailCall())
+  if (!EnableARMTailCalls || !Subtarget->supportsTailCall())
     isTailCall = false;
   if (isTailCall) {
     // Check if it's really possible to do a tail call.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1069.1.patch
Type: text/x-patch
Size: 552 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130629/b0fdf440/attachment.bin>


More information about the llvm-commits mailing list