[llvm] r185169 - Bug 13662: Enable GPRPair for all i64 operands of inline asm on ARM

Weiming Zhao weimingz at codeaurora.org
Fri Jun 28 13:26:46 PDT 2013


Thanks. Sorry, I overlooked the warnings. :(

Eric, thanks for fixing that for me. 

Weiming

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation


-----Original Message-----
From: Eric Christopher [mailto:echristo at gmail.com] 
Sent: Friday, June 28, 2013 1:07 PM
To: Renato Golin
Cc: Weiming Zhao; llvm-commits at cs.uiuc.edu
Subject: Re: [llvm] r185169 - Bug 13662: Enable GPRPair for all i64 operands
of inline asm on ARM

On Fri, Jun 28, 2013 at 1:05 PM, Renato Golin <renato.golin at linaro.org>
wrote:
> On 28 June 2013 19:05, Eric Christopher <echristo at gmail.com> wrote:
>>
>> You left a bunch of warnings for unused variables in, I've fixed them 
>> for you here:
>>
>> M lib/Target/ARM/ARMISelDAGToDAG.cpp
>> Committed r185180
>
>
> Thanks Eric!
>
> Weiming, we treat warning as errors, especially on new additions. So 
> if you could always use -Werror when compiling, that'd be great.
>

FWIW if you use configure there's a --enable-werror configure line.
I'm sure there's something analogous for cmake :)

-eric




More information about the llvm-commits mailing list