[llvm] r185184 - Add a division operator to BlockFrequency.

Jakob Stoklund Olesen stoklund at 2pi.dk
Fri Jun 28 12:16:04 PDT 2013


On Jun 28, 2013, at 12:09 PM, Benjamin Kramer <benny.kra at gmail.com> wrote:
>> +  // If the product fits in 64 bits, just use built-in division.
>> +  if (MulHi <= UINT32_MAX && MulRes <= MulLo) {
> 
> The right side checks that the addition didn't overflow, shouldn't it be MulRes >= MulLo?

Right you are. I’ll try to come up with a test case.

Thanks,
/jakob





More information about the llvm-commits mailing list