[PATCH] [sanitizer] Support padding with spaces in Printf.

Alexey Samsonov samsonov at google.com
Thu Jun 27 08:27:25 PDT 2013


  LGTM


================
Comment at: lib/sanitizer_common/sanitizer_printf.cc:71
@@ +70,3 @@
+  pos--;
+  while (pos >= 0 && num_buffer[pos] == 0) {
+    char c = (pad_with_zero || pos == 0) ? '0' : ' ';
----------------
I'd prefer
for (;pos >= 0 && num_buffer[pos] == 0; pos--) { ... }
here and below.


http://llvm-reviews.chandlerc.com/D1057

BRANCH
  feat/sanitizer/printf-padding

ARCANIST PROJECT
  compiler-rt



More information about the llvm-commits mailing list