Address spaces in MC are completely untested

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Jun 27 06:43:43 PDT 2013


Reviewing http://llvm-reviews.chandlerc.com/D1043 I noticed that
implementation of address spaces in MC was a bit messy. Parts of some
streamers support it, others parts ignore it and yet others assert
that it is 0.

I wanted to refactor it, but there is a problem: We don't have *any*
tests. Is this used only by out of tree targets? What about R600,
doesn't it use address spaces? Only for dynamic memory?

Another option is that all data in object files is in the default
address space for all targets and this patch removes dead code.
Without tests it is hard to tell.

If you have an out of tree target that uses address spaces, please try
this patch and let me know if it breaks something for you.

This was added back in r63377 by Sanjiv Gupta from microchip, so it is
possible that this was only used by PIC and is really dead code.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 42305 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130627/70ad45df/attachment.obj>


More information about the llvm-commits mailing list