[llvm] r185040 - SLP: Dont erase instructions during vectorization because it prevents the outerloops from iterating over the instructions.

Eric Christopher echristo at gmail.com
Wed Jun 26 17:03:19 PDT 2013


On Wed, Jun 26, 2013 at 5:00 PM, Nadav Rotem <nrotem at apple.com> wrote:
>
> On Jun 26, 2013, at 4:55 PM, Chandler Carruth <chandlerc at google.com> wrote:
>
> It may not be worth it, but I found in SROA it was much more efficient to
> keep a local vector of dead instructions that I manually went and deleted at
> the end of the pass. That way you don't have iterator invalidation concerns,
> but you also don't re-do the work to prove them dead.
>
>
> That’s what I do with the code that does local CSE. I will probably go back
> and add the vector of deleted instructions for this as well.

Seems like something that should be done, yeah.

Thanks!

-eric




More information about the llvm-commits mailing list