[PATCH] [Object] Split the ELF interface into 3 parts.

Michael Spencer bigcheesegs at gmail.com
Wed Jun 26 11:26:23 PDT 2013



================
Comment at: include/llvm/Object/ELF.h:1550
@@ +1549,3 @@
+template <class ELFT>
+ErrorOr<StringRef>
+ELFFile<ELFT>::getSectionName(const Elf_Shdr *Section) const {
----------------
Rafael Ávila de Espíndola wrote:
> This never fails. Please just return a StringRef.
We will need to verify that Section->sh_name is valid.


http://llvm-reviews.chandlerc.com/D1033



More information about the llvm-commits mailing list