[PATCH] [PATCH] Add a subtarget feature "v8" to ARM
joey.gouly at arm.com
Wed Jun 26 07:00:17 PDT 2013
> To me it looks like there are a couple of patches here:
> + Support v8
> + Stop emitting v7 attributes when the compiler has really selected something like v4
Yes, that's right. Shall I split out the attributes part first? Or can I just commit them separately? I had to do that for the v8 attributes to work. It used to first check that the CPU was "generic", and if so, emit attributes for a v7a, whereas codegen emits for v4 by default.
> The latter change appears to have no tests.
That's the change to the 'mc-elf-objheader.ll' file.
> Are you really sure you want to support v8m at this stage, let alone
> in such a half-hearted way? I'd have wanted to get the v8a features
> correct first, since if nothing else cortex-a53 is an A-class core.
No, that should be removed, thanks.
> It would also be good to see a test for "thumbv8" since that's likely
> to be used quite a bit.
CHANGE SINCE LAST DIFF
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 8770 bytes
Desc: not available
More information about the llvm-commits