[polly] r184529 - Use isl_val instead of isl_int in the core of Polly

[Andy Gibbs]

On Friday, June 21, 2013 8:41 AM, Tobias Grosser wrote:
> Author: grosser
> Date: Fri Jun 21 01:41:31 2013
> New Revision: 184529
>
> URL: http://llvm.org/viewvc/llvm-project?rev=184529&view=rev
> Log:
> Use isl_val instead of isl_int in the core of Polly
>
> isl recently introduced isl_val as an abstract interface to represent 
> arbitrary
> precision numbers. This interface superseeds the old isl_int interface. In
> contrast to the old interface which implemented arbitrary precision 
> arithmetic
> using macros that forward to the gmp library, the new library hides the 
> math
> library implementation in isl. This allows us to switch the math library 
> used by
> isl without affecting users such as Polly.
>
> Modified:
>    polly/trunk/include/polly/CodeGen/CodeGeneration.h
>    polly/trunk/include/polly/Support/GICHelper.h
>    polly/trunk/lib/Analysis/ScopInfo.cpp
>    polly/trunk/lib/CodeGen/BlockGenerators.cpp
>    polly/trunk/lib/CodeGen/IslCodeGeneration.cpp
>    polly/trunk/lib/ScheduleOptimizer.cpp
>    polly/trunk/lib/Support/GICHelper.cpp
>    polly/trunk/utils/checkout_cloog.sh
>
> [...snip...]
>
> Modified: polly/trunk/utils/checkout_cloog.sh
> URL: 
> http://llvm.org/viewvc/llvm-project/polly/trunk/utils/checkout_cloog.sh?rev=184529&r1=184528&r2=184529&view=diff
> ==============================================================================
> --- polly/trunk/utils/checkout_cloog.sh (original)
> +++ polly/trunk/utils/checkout_cloog.sh Fri Jun 21 01:41:31 2013
> @@ -1,7 +1,7 @@
> #!/bin/sh
>
> CLOOG_HASH="f861f854b6cc85b67e39794e38e7104fcd59af90"
> -ISL_HASH="1df91d8515ec88dc7f7f597168ad0f34f26de5a7"
> +ISL_HASH="0a83197c479109b0f7c327484b80a878f291b296"
>
> PWD=`pwd`

I'm afraid this change regresses your fix in r184064.

Below is the output I get from a "make check" of cloog.

Cheers,
Andy

----

Check file build/cloog/test/isl/unroll.cloog (options -first-unroll 1 ), 
generating... PASS
Check file build/cloog/test/isl/jacobi-shared.cloog (options -f 
4 -l -1 -override -strides 1 -sh 1 ), generating... --- cloog_temp 
2013-06-24 09:11:25.000000000 +0200
+++ build/cloog/test/isl/jacobi-shared.c      2013-06-24 08:48:29.000000000 
+0200
@@ -1,6 +1,6 @@
-/* Generated from build/cloog/test/isl/jacobi-shared.cloog by CLooG 
0.18.0-3-gf861f85 gmp bits in 0.41s. */
+/* Generated from ../../../git/cloog/test/isl/jacobi-shared.cloog by CLooG 
0.16.3-2-g5511bef gmp bits in 1.82s. */
 if ((h0+1)%2 == 0) {
-  if ((16*floord(t0-1,16) >= -N+g1+t0+1) && (16*floord(g1+t0-3,16) 
 >= -N+g1+t0+1) && (32*floord(t1-1,32) >= -N+g2+t1+1) && 
(32*floord(g2+t1-3,32) >= t1-32)) {
+  if ((16*floord(N+15*t0+15,16) >= 15*t0+19) && (16*floord(N+15*t0+15,16) 
 >= g1+15*t0+17) && (32*floord(t1-1,32) <= g2+t1-3) && (32*floord(t1-1,32) 
 >= -N+g2+t1+1)) {
     for 
(c0=max(-16*floord(t0-1,16)+t0,-16*floord(g1+t0-3,16)+t0);c0<=min(32,N-g1-1);c0+=16) 
{
       for (c1=-32*floord(t1-1,32)+t1;c1<=min(32,N-g2-1);c1+=32) {
         if ((c1 >= 1) && (c1 <= 32)) {
-e FAIL: build/cloog/test/isl/jacobi-shared.c is not the same
Check file build/cloog/test/isl/unroll2.cloog (options -first-unroll 1 ), 
generating... PASS
Check file build/cloog/test/backtrack.cloog (options -f 1 -backtrack ), 
generating... PASS
Check file build/cloog/test/vasilache.cloog (options -f 8 -l 9 ), 
generating... PASS
Check file build/cloog/test/merge.cloog (options -f -1 ), generating... PASS
Check file build/cloog/test/equality.cloog (options -f -1 -l 2 -override ), 
generating... PASS
Check file build/cloog/test/equality2.cloog (options -f -1 -l 4 -esp 
1 -override ), generating... PASS
Check file build/cloog/test/otl.cloog (options -block 1 -esp 0 -otl 0 ), 
generating... PASS
Check file build/cloog/test/param-split.cloog (options -f -1 ), 
generating... PASS
Check file build/cloog/test/pouchet.cloog (options -f 3 -l 7 ), 
generating... PASS
Check file build/cloog/test/stride.cloog (options -f -1 -strides 1 ), 
generating... PASS
Check file build/cloog/test/stride2.cloog (options -f -1 -strides 1 ), 
generating... PASS
Check file build/cloog/test/sor1d.cloog (options -f -1 ), generating... PASS
[CLooG] FAIL: 1 tests failed in SPECIAL
FAIL: build/cloog/test/check_special.sh
===================================================
1 of 5 tests failed
Please report to cloog-development at googlegroups.com
===================================================