[lld] r184682 - [lld] rename member variable name.

Shankar Easwaran shankare at codeaurora.org
Sun Jun 23 20:22:51 PDT 2013


Author: shankare
Date: Sun Jun 23 22:22:51 2013
New Revision: 184682

URL: http://llvm.org/viewvc/llvm-project?rev=184682&view=rev
Log:
[lld] rename member variable name.

This renames variable name to reflect initial undefined symbols that are
defined by the linker -u option.

This doesnot change any functionality in lld, and updates code to reflect
Nick's comment.

Modified:
    lld/trunk/include/lld/Core/TargetInfo.h
    lld/trunk/lib/Driver/GnuLdDriver.cpp
    lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h

Modified: lld/trunk/include/lld/Core/TargetInfo.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/TargetInfo.h?rev=184682&r1=184681&r2=184682&view=diff
==============================================================================
--- lld/trunk/include/lld/Core/TargetInfo.h (original)
+++ lld/trunk/include/lld/Core/TargetInfo.h Sun Jun 23 22:22:51 2013
@@ -241,8 +241,8 @@ public:
   /// This method adds undefined symbols specified by the -u option to the
   /// to the list of undefined symbols known to the linker. This option
   /// essentially forces an undefined symbol to be create.
-  void addUndefinedSymbol(StringRef symbolName) {
-    _undefinedSymbols.push_back(symbolName);
+  void addInitialUndefinedSymbol(StringRef symbolName) {
+    _initialUndefinedSymbols.push_back(symbolName);
   }
 
   /// Iterators for symbols that appear on the command line
@@ -252,8 +252,8 @@ public:
 
   /// Return the list of undefined symbols that are specified in the
   /// linker command line, using the -u option.
-  range<const StringRef *> undefinedSymbols() const {
-    return _undefinedSymbols;
+  range<const StringRef *> initialUndefinedSymbols() const {
+    return _initialUndefinedSymbols;
   }
 
   /// After all set* methods are called, the Driver calls this method
@@ -359,7 +359,7 @@ protected:
   std::vector<LinkerInput> _inputFiles;
   std::vector<const char*> _llvmOptions;
   std::unique_ptr<Reader>  _yamlReader;
-  StringRefVector          _undefinedSymbols;
+  StringRefVector          _initialUndefinedSymbols;
 
  private:
   /// Validate the subclass bits. Only called by validate.

Modified: lld/trunk/lib/Driver/GnuLdDriver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/GnuLdDriver.cpp?rev=184682&r1=184681&r2=184682&view=diff
==============================================================================
--- lld/trunk/lib/Driver/GnuLdDriver.cpp (original)
+++ lld/trunk/lib/Driver/GnuLdDriver.cpp Sun Jun 23 22:22:51 2013
@@ -221,7 +221,7 @@ GnuLdDriver::parse(int argc, const char
   for (llvm::opt::arg_iterator it = parsedArgs->filtered_begin(OPT_u),
                                ie = parsedArgs->filtered_end();
        it != ie; ++it) {
-    options->addUndefinedSymbol((*it)->getValue());
+    options->addInitialUndefinedSymbol((*it)->getValue());
   }
 
   // Handle -Lxxx

Modified: lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h?rev=184682&r1=184681&r2=184682&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h Sun Jun 23 22:22:51 2013
@@ -240,7 +240,7 @@ void OutputELFWriter<ELFT>::addFiles(Inp
   _targetHandler.addFiles(inputFiles);
   // Add all symbols that are specified by the -u option
   // as part of the command line argument to lld
-  for (auto ai : _targetInfo.undefinedSymbols())
+  for (auto ai : _targetInfo.initialUndefinedSymbols())
     _linkerInternalFile.addUndefinedAtom(ai);
   // Make the linker internal file to be the first file
   inputFiles.prependFile(_linkerInternalFile);





More information about the llvm-commits mailing list