[llvm] r184602 - Put r184469 disassembler test back on X86

[Sean Silva]

On Fri, Jun 21, 2013 at 4:12 PM, Renato Golin <renato.golin at linaro.org>wrote:

> On 21 June 2013 23:59, Sean Silva <silvas at purdue.edu> wrote:
>
>> Thanks for doing this, but I'm probably going to revert this change for
>> the time being and just remove the disassembly part altogether. This test
>> really shouldn't be X86 specific (the disassembly things was mostly just
>> because "it was kinda neat and available right there in llvm-objdump"; but
>> it turns out that it's not always available, so no big deal). The most
>> important thing in this test is that `main` has Value 1 and Size 2, and I
>> would prefer not to lose coverage of that on non-x86 platforms.
>>
>
> No worries, feel free to change it as you see fit. Just remember that on
> ARM we don't build any other backend, so non-ARM triples are actually
> invalid and need to go into "X86", "MIPS" etc directories. ;)
>

It looks like a similar issue occurred with <
http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/8973/steps/check-all/logs/Clang%3A%3Anvptx-inlineasm-ptx.c>.
Maybe you could document that tests depending on specific targets being
built need to be placed in corresponding directories? Maybe in <
http://llvm.org/docs/TestingGuide.html#writing-new-regression-tests>?

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130621/b9a1cb02/attachment.html>