submit [PATCH] SimplifyCFG for code review

[Renato Golin]

On 21 June 2013 18:09, Ye, Mei <Mei.Ye at amd.com> wrote:

>  So the question is:  if there is a requirement of proof, is there a
> standard on which architecture with what kind of machine configurations?
>

You took of part my comment a bit too literally, and not the most important
part, I'm afraid. It's not a matter of running "a" set of benchmarks on "a"
list of configurations that will "prove" your patch is good, it's a matter
of thinking how we can apply the transformation you need into LLVM without
breaking unknown code on unknown targets.

As Evan said, you probably implemented the transformation in the wrong
place, and what we have to do now is to understand what is the best place
to put it, not run benchmarks.

Also, it should be specific to your target unless it benefits the majority
of targets (here is where things get confusing), and even that, should be
done slowly. If you implement in the back-end, or close to it, than it'll
be easier to make it specific. If not, you'll have to create a compiler
flag and leave it disabled by default. By Evan's comments, I guess you'll
be safer with the former option.

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130621/676468c9/attachment.html>