[llvm] r184486 - Add a fixme.

Rafael Espindola rafael.espindola at gmail.com
Thu Jun 20 15:04:56 PDT 2013


Author: rafael
Date: Thu Jun 20 17:04:56 2013
New Revision: 184486

URL: http://llvm.org/viewvc/llvm-project?rev=184486&view=rev
Log:
Add a fixme.

Modified:
    llvm/trunk/tools/llvm-ar/llvm-ar.cpp

Modified: llvm/trunk/tools/llvm-ar/llvm-ar.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-ar/llvm-ar.cpp?rev=184486&r1=184485&r2=184486&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-ar/llvm-ar.cpp (original)
+++ llvm/trunk/tools/llvm-ar/llvm-ar.cpp Thu Jun 20 17:04:56 2013
@@ -428,6 +428,7 @@ doExtract(std::string* ErrMsg) {
 
       // Retain the original mode.
       sys::fs::perms Mode = sys::fs::perms(I->getMode());
+      // FIXME: at least on posix we should be able to reuse FD (fchmod).
       error_code EC = sys::fs::permissions(I->getPath(), Mode);
       if (EC)
         fail(EC.message());





More information about the llvm-commits mailing list