[llvm] r184449 - [APFloat] Rename isIEEENormal => isNormal and remove old isNormal method.

Michael Gottesman mgottesman at apple.com
Thu Jun 20 11:34:38 PDT 2013


Author: mgottesman
Date: Thu Jun 20 13:34:38 2013
New Revision: 184449

URL: http://llvm.org/viewvc/llvm-project?rev=184449&view=rev
Log:
[APFloat] Rename isIEEENormal => isNormal and remove old isNormal method.

The old isNormal is already functionally replaced by the method isFiniteNonZero
in r184350 and all references to said method were replaced in LLVM/clang in
r184356/134366.

Modified:
    llvm/trunk/include/llvm/ADT/APFloat.h
    llvm/trunk/unittests/ADT/APFloatTest.cpp

Modified: llvm/trunk/include/llvm/ADT/APFloat.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/APFloat.h?rev=184449&r1=184448&r2=184449&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ADT/APFloat.h (original)
+++ llvm/trunk/include/llvm/ADT/APFloat.h Thu Jun 20 13:34:38 2013
@@ -362,7 +362,7 @@ public:
   ///
   /// The current implementation of isNormal() differs from this by treating
   /// subnormal values as normal values.
-  bool isIEEENormal() const { return !isDenormal() && isFiniteNonZero(); }
+  bool isNormal() const { return !isDenormal() && isFiniteNonZero(); }
 
   /// Returns true if and only if the current value is zero, subnormal, or
   /// normal.
@@ -394,7 +394,6 @@ public:
   fltCategory getCategory() const { return category; }
   const fltSemantics &getSemantics() const { return *semantics; }
   bool isNonZero() const { return category != fcZero; }
-  bool isNormal() const { return category == fcNormal; }
   bool isFiniteNonZero() const { return isFinite() && !isZero(); }
   bool isPosZero() const { return isZero() && !isNegative(); }
   bool isNegZero() const { return isZero() && isNegative(); }

Modified: llvm/trunk/unittests/ADT/APFloatTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/APFloatTest.cpp?rev=184449&r1=184448&r2=184449&view=diff
==============================================================================
--- llvm/trunk/unittests/ADT/APFloatTest.cpp (original)
+++ llvm/trunk/unittests/ADT/APFloatTest.cpp Thu Jun 20 13:34:38 2013
@@ -1417,15 +1417,15 @@ TEST(APFloatTest, isNegative) {
   EXPECT_TRUE(APFloat::getSNaN(APFloat::IEEEsingle, true).isNegative());
 }
 
-TEST(APFloatTest, isIEEENormal) {
+TEST(APFloatTest, isNormal) {
   APFloat t(APFloat::IEEEsingle, "0x1p+0");
-  EXPECT_TRUE(t.isIEEENormal());
+  EXPECT_TRUE(t.isNormal());
   
-  EXPECT_FALSE(APFloat::getInf(APFloat::IEEEsingle, false).isIEEENormal());
-  EXPECT_FALSE(APFloat::getZero(APFloat::IEEEsingle, false).isIEEENormal());
-  EXPECT_FALSE(APFloat::getNaN(APFloat::IEEEsingle, false).isIEEENormal());
-  EXPECT_FALSE(APFloat::getSNaN(APFloat::IEEEsingle, false).isIEEENormal());  
-  EXPECT_FALSE(APFloat(APFloat::IEEEsingle, "0x1p-149").isIEEENormal());
+  EXPECT_FALSE(APFloat::getInf(APFloat::IEEEsingle, false).isNormal());
+  EXPECT_FALSE(APFloat::getZero(APFloat::IEEEsingle, false).isNormal());
+  EXPECT_FALSE(APFloat::getNaN(APFloat::IEEEsingle, false).isNormal());
+  EXPECT_FALSE(APFloat::getSNaN(APFloat::IEEEsingle, false).isNormal());  
+  EXPECT_FALSE(APFloat(APFloat::IEEEsingle, "0x1p-149").isNormal());
 }
 
 TEST(APFloatTest, isFinite) {





More information about the llvm-commits mailing list