[PATCH] ARM: enable decoding of pc-relative PLD/PLI

Renato Golin renato.golin at linaro.org
Thu Jun 20 06:32:49 PDT 2013


  Rest looks ok to me


================
Comment at: lib/Target/ARM/ARMInstrThumb2.td:1039
@@ -1038,1 +1038,3 @@
+    bits<13> addr;
+    let Inst{23} = addr{12}; // add = (U == '1')
     let Inst{11-0}  = addr{11-0};
----------------
This seems like a pointless movement of code...

================
Comment at: lib/Target/ARM/ARMInstrThumb2.td:1642
@@ +1641,3 @@
+
+    let DecoderMethod = "DecodeT2LoadLabel";
+  }
----------------
Shouldn't this be DecodeT2LoadImm12?


http://llvm-reviews.chandlerc.com/D1001



More information about the llvm-commits mailing list