[llvm] r184271 - Remove unused parameter.

Sean Silva silvas at purdue.edu
Wed Jun 19 11:42:07 PDT 2013


On Tue, Jun 18, 2013 at 7:46 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
> On Jun 18, 2013 6:12 PM, "Sean Silva" <silvas at purdue.edu> wrote:
> > Not sure why we weren't catching this with -Wunused-parameter...
>
> Could you narrow down case test case and file a bug?
>
Actually, it turns out that llvm's build has -Wno-unused-parameter enabled.
The following is from `cmake/modules/HandleLLVMOptions.cmake`:

elseif( LLVM_COMPILER_IS_GCC_COMPATIBLE )
  if (LLVM_ENABLE_WARNINGS)
    append("-Wall -W -Wno-unused-parameter -Wwrite-strings" CMAKE_C_FLAGS
CMAKE_CXX_FLAGS)

The makefiles have something similar.

A bit of archaeology (bless git's "pickaxe" functionality!) reveals that
this was introduced in r31380 in 2006, and has been copied forward ever
since.

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130619/971564ab/attachment.html>


More information about the llvm-commits mailing list