submit [PATCH] SimplifyCFG for code review

Sean Silva silvas at purdue.edu
Tue Jun 18 16:48:25 PDT 2013


On Tue, Jun 18, 2013 at 4:27 PM, Ye, Mei <Mei.Ye at amd.com> wrote:

>  Hi Sean****
>
> ** **
>
> There are some considerations that go into this test sample to create an
> opportunity for the transformation.
>
The test case should run *only* the simplifycfg pass (I see now that you
have `-O3` in your test case; please remove `-O3`). You can probably just
write a simple .ll function with IR that looks like the "Before" case in
your documentation comment.

Also,

+; RUN: opt < %s -O3 -simplifycfg -S | grep br | count 2
+%struct.float2_tag = type { float, float }

Please use FileCheck for all new tests. Using grep is deprecated.

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130618/edf51446/attachment.html>


More information about the llvm-commits mailing list