[llvm] r184162 - [yaml2obj][ELF] Factor out string table section creation.

Sean Silva silvas at purdue.edu
Mon Jun 17 18:11:27 PDT 2013


Author: silvas
Date: Mon Jun 17 20:11:27 2013
New Revision: 184162

URL: http://llvm.org/viewvc/llvm-project?rev=184162&view=rev
Log:
[yaml2obj][ELF] Factor out string table section creation.

Modified:
    llvm/trunk/tools/yaml2obj/yaml2elf.cpp

Modified: llvm/trunk/tools/yaml2obj/yaml2elf.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/yaml2obj/yaml2elf.cpp?rev=184162&r1=184161&r2=184162&view=diff
==============================================================================
--- llvm/trunk/tools/yaml2obj/yaml2elf.cpp (original)
+++ llvm/trunk/tools/yaml2obj/yaml2elf.cpp Mon Jun 17 20:11:27 2013
@@ -120,6 +120,19 @@ static void zero(T &Obj) {
   memset(&Obj, 0, sizeof(Obj));
 }
 
+/// \brief Create a string table in `SHeader`, which we assume is already
+/// zero'd.
+template <class Elf_Shdr>
+static void createStringTableSectionHeader(Elf_Shdr &SHeader,
+                                           StringTableBuilder &STB,
+                                           ContiguousBlobAccumulator &CBA) {
+  SHeader.sh_type = ELF::SHT_STRTAB;
+  SHeader.sh_offset = CBA.currentOffset();
+  SHeader.sh_size = STB.size();
+  STB.writeToStream(CBA.getOS());
+  SHeader.sh_addralign = 1;
+}
+
 template <class ELFT>
 static int writeELF(raw_ostream &OS, const ELFYAML::Object &Doc) {
   using namespace llvm::ELF;
@@ -220,17 +233,7 @@ static int writeELF(raw_ostream &OS, con
   // Section header string table header.
   Elf_Shdr SHStrTabSHeader;
   zero(SHStrTabSHeader);
-  SHStrTabSHeader.sh_name = 0;
-  SHStrTabSHeader.sh_type = SHT_STRTAB;
-  SHStrTabSHeader.sh_flags = 0;
-  SHStrTabSHeader.sh_addr = 0;
-  SHStrTabSHeader.sh_offset = CBA.currentOffset();
-  SHStrTabSHeader.sh_size = SHStrTab.size();
-  SHStrTab.writeToStream(CBA.getOS());
-  SHStrTabSHeader.sh_link = 0;
-  SHStrTabSHeader.sh_info = 0;
-  SHStrTabSHeader.sh_addralign = 1;
-  SHStrTabSHeader.sh_entsize = 0;
+  createStringTableSectionHeader(SHStrTabSHeader, SHStrTab, CBA);
 
   OS.write((const char *)&Header, sizeof(Header));
   writeVectorData(OS, SHeaders);





More information about the llvm-commits mailing list