[llvm] r183985 - Remove a use of PathV1.h.

[Lang Hames]

Hi Rafael,

No worries. Thanks for fixing it so quickly.

Just so I understand - the plan is ultimately to add these checks to
sys::fs::remove? (Or add a "safe" remove variant that does the checks)?

Once that's done we should be able to re-apply your patch, right?

Cheers,
Lang.



On Mon, Jun 17, 2013 at 12:56 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> On 17 June 2013 15:48, Lang Hames <lhames at gmail.com> wrote:
> > Hi Rafael,
> >
> > This broke an internal tester. The eraseFromDisk() method contains some
> > checks for special files to prevent it from removing anything important.
> >
> > We really want to keep those checks in place. I'm not familiar with the
> path
> > library work - what is the best way to resolve this? Should this be
> > reverted, or can the checks be added to sys::fs::remove?
>
>
> Thanks for catching this. I reverted this in 184111. I will add the
> missing functionality to PathV2.h.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130617/b60115be/attachment.html>