[llvm] r184130 - MI-Sched: Remove another heuristic that is sensitive to queue order.

Andrew Trick atrick at apple.com
Mon Jun 17 14:45:07 PDT 2013


Author: atrick
Date: Mon Jun 17 16:45:07 2013
New Revision: 184130

URL: http://llvm.org/viewvc/llvm-project?rev=184130&view=rev
Log:
MI-Sched: Remove another heuristic that is sensitive to queue order.

Modified:
    llvm/trunk/lib/CodeGen/MachineScheduler.cpp

Modified: llvm/trunk/lib/CodeGen/MachineScheduler.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineScheduler.cpp?rev=184130&r1=184129&r2=184130&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/MachineScheduler.cpp (original)
+++ llvm/trunk/lib/CodeGen/MachineScheduler.cpp Mon Jun 17 16:45:07 2013
@@ -2113,15 +2113,9 @@ void ConvergingScheduler::tryCandidate(S
     return;
 
   // Weak edges are for clustering and other constraints.
-  //
-  // Deferring TryCand here does not change Cand's reason. This is good in the
-  // sense that a bad candidate shouldn't affect a previous candidate's
-  // goodness, but bad in that it is assymetric and depends on queue order.
-  CandReason OrigReason = Cand.Reason;
   if (tryLess(getWeakLeft(TryCand.SU, Zone.isTop()),
               getWeakLeft(Cand.SU, Zone.isTop()),
               TryCand, Cand, Weak)) {
-    Cand.Reason = OrigReason;
     return;
   }
   // Avoid critical resource consumption and balance the schedule.





More information about the llvm-commits mailing list