[llvm] r184074 - Fix incorrectly finding 'executable' directories instead of files.

[Rafael Espíndola]

On 17 June 2013 06:48, Manuel Klimek <klimek at google.com> wrote:
> Author: klimek
> Date: Mon Jun 17 05:48:34 2013
> New Revision: 184074
>
> URL: http://llvm.org/viewvc/llvm-project?rev=184074&view=rev
> Log:
> Fix incorrectly finding 'executable' directories instead of files.
>
> This broke for example the 'not' utility, if a directory called
> 'FileCheck' is executable and in the path before the actual 'FileCheck'.
>
> This patch steals the implementation of the "old" PathV1 canExecute
> implementation:
> - checks for R_OK (file readable): this is necessary for executing
>   scripts; we should not regress here unless we have good reasons

This is ok.

> - checks for S_ISREG; if we want to get rid of this, we'd need to
>   change all callers who already made the assumption when depending
>   on Path V1.

Sigh, I was hopping to avoid the cost, but yes, it is better to have it for now.

I will try to add testcases.

Thanks,
Rafael