[llvm] r184026 - Debug Info: Don't print the display name and colon prefix for DEBUG_VALUE comments if the display name is empty

David Blaikie dblaikie at gmail.com
Fri Jun 14 17:33:48 PDT 2013


Author: dblaikie
Date: Fri Jun 14 19:33:47 2013
New Revision: 184026

URL: http://llvm.org/viewvc/llvm-project?rev=184026&view=rev
Log:
Debug Info: Don't print the display name and colon prefix for DEBUG_VALUE comments if the display name is empty

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    llvm/trunk/test/CodeGen/X86/dbg-value-terminator.ll

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=184026&r1=184025&r2=184026&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Fri Jun 14 19:33:47 2013
@@ -562,8 +562,11 @@ static bool emitDebugValueComment(const
 
   // cast away const; DIetc do not take const operands for some reason.
   DIVariable V(const_cast<MDNode*>(MI->getOperand(2).getMetadata()));
-  if (V.getContext().isSubprogram())
-    OS << DISubprogram(V.getContext()).getDisplayName() << ":";
+  if (V.getContext().isSubprogram()) {
+    StringRef Name = DISubprogram(V.getContext()).getDisplayName();
+    if (!Name.empty())
+      OS << Name << ":";
+  }
   OS << V.getName() << " <- ";
 
   // Register or immediate value. Register 0 means undef.

Modified: llvm/trunk/test/CodeGen/X86/dbg-value-terminator.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/dbg-value-terminator.ll?rev=184026&r1=184025&r2=184026&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/dbg-value-terminator.ll (original)
+++ llvm/trunk/test/CodeGen/X86/dbg-value-terminator.ll Fri Jun 14 19:33:47 2013
@@ -6,7 +6,7 @@
 ; terminator.
 ;
 ; CHECK: test:
-; CHECK: ##DEBUG_VALUE: :i
+; CHECK: ##DEBUG_VALUE: i
 %a = type { i32, i32 }
 
 define hidden fastcc %a* @test() #1 {





More information about the llvm-commits mailing list