[llvm] r183994 - Do not to perform RUN line substitution of llc if that's prefixed by a hypnen

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Jun 14 12:45:10 PDT 2013


btw, llvmc is long dead, why not remove it.

Going back to the original question: For clang we ignore -clang and
/clang. Why not do the same for llc (and maybe all tools?).

Cheers,
Rafael


On 14 June 2013 15:14, Eli Bendersky <eliben at google.com> wrote:
> Author: eliben
> Date: Fri Jun 14 14:14:52 2013
> New Revision: 183994
>
> URL: http://llvm.org/viewvc/llvm-project?rev=183994&view=rev
> Log:
> Do not to perform RUN line substitution of llc if that's prefixed by a hypnen
> (-llc), similarly to the way it was done for clang and llvmc.
>
> This doesn't affect the upstream llvm tests but helps when developing custom
> LLVM-based tools and testing them within the LLVM regression framework.
>
> Modified:
>     llvm/trunk/test/lit.cfg
>
> Modified: llvm/trunk/test/lit.cfg
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/lit.cfg?rev=183994&r1=183993&r2=183994&view=diff
> ==============================================================================
> --- llvm/trunk/test/lit.cfg (original)
> +++ llvm/trunk/test/lit.cfg Fri Jun 14 14:14:52 2013
> @@ -201,9 +201,14 @@ if os.pathsep == ';':
>      pathext = os.environ.get('PATHEXT', '').split(';')
>  else:
>      pathext = ['']
> +# Regex to reject matching a hyphen
> +NOHYPHEN = r"(?<!-)"
> +
>  for pattern in [r"\bbugpoint\b(?!-)",   r"(?<!/|-)\bclang\b(?!-)",
>                  r"\bgold\b",
> -                r"\bllc\b",             r"\blli\b",
> +                # Match llc but not -llc
> +                NOHYPHEN + r"\bllc\b",
> +                r"\blli\b",
>                  r"\bllvm-ar\b",         r"\bllvm-as\b",
>                  r"\bllvm-bcanalyzer\b", r"\bllvm-config\b",
>                  r"\bllvm-cov\b",        r"\bllvm-diff\b",
> @@ -214,8 +219,9 @@ for pattern in [r"\bbugpoint\b(?!-)",
>                  r"\bllvm-prof\b",       r"\bllvm-ranlib\b",
>                  r"\bllvm-rtdyld\b",     r"\bllvm-shlib\b",
>                  r"\bllvm-size\b",
> -                # Don't match '-llvmc'.
> -                r"(?<!-)\bllvmc\b",     r"\blto\b",
> +                # Match llvmc but not -llvmc
> +                NOHYPHEN + r"\bllvmc\b",
> +                r"\blto\b",
>                                          # Don't match '.opt', '-opt',
>                                          # '^opt' or '/opt'.
>                  r"\bmacho-dump\b",      r"(?<!\.|-|\^|/)\bopt\b",
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list