[llvm] r183966 - Enable FastISel on ARM for Linux and NaCl, not MCJIT

Eric Christopher echristo at gmail.com
Fri Jun 14 11:16:08 PDT 2013


On Fri, Jun 14, 2013 at 8:32 AM, Renato Golin <renato.golin at linaro.org> wrote:
> On 14 June 2013 15:55, JF Bastien <jfb at google.com> wrote:
>>
>> Which is the better fix? ARM FastISel (and therefore O0) now has disable
>> frame pointer elimination on by default, so the DW_AT_APPLE_omit_frame_ptr
>> debug information shouldn't be present in either test case.
>

We should probably leave a frame pointer on at all times for fast-isel
and, in general, at O0. I made a change in the front end as well for
this a while back.

>
> If that's true, than the test is not necessary any more. I'd consult a
> Darwin specialist first, though.
>

The test was originally just to check the name and make sure it showed
up when it was supposed to. Could just as easily add the option to
enable and disable fast-isel or (even easier) run the positive check
(that the attribute is there) at O1.

-eric



More information about the llvm-commits mailing list