[PATCH] SelectionDAG: Fix incorrect condition checks in some cases of folding FADD/FMUL combinations

Stephen Lin swlin at apple.com
Fri Jun 14 09:12:14 PDT 2013


Hi,

This is a fix for a bug noticed while in the process of implementing a different patch...a case was duplicated and order of operands was swapped, but some variable names were missed.

Fairly obvious fix, but it would be nice to have another set of eyes look over it to make sure that I didn’t miss anything else.

Also, some comments were slightly inaccurate so I fixed the comments to match what the code was doing. Alternatively, I could have fixed the code to match the comments, but it didn’t seem like there would be any benefit to doing so in this case.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-unsafe-combine-fadd.patch
Type: application/octet-stream
Size: 10283 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130614/2978e4be/attachment.obj>
-------------- next part --------------


Thanks,
Stephen


More information about the llvm-commits mailing list