[PATCH] ARM: thumb byte & halfword stores cannot use PC as dest register

Renato Golin renato.golin at linaro.org
Thu Jun 13 13:52:57 PDT 2013


  You seem to be adding more cases than tests, do they overlap?


================
Comment at: lib/Target/ARM/Disassembler/ARMDisassembler.cpp:3173
@@ +3172,3 @@
+      return MCDisassembler::Fail;
+  default:
+    break;
----------------
Style nitpick: we normally put the default as the first item.

But I see that others follow the style you used in this file. I'm fine either way.


http://llvm-reviews.chandlerc.com/D972



More information about the llvm-commits mailing list