[PATCH] [ELF] Add NMAGIC/OMAGIC support

Shankar Kalpathi Easwaran shankarke at gmail.com
Wed Jun 12 21:58:51 PDT 2013



================
Comment at: lib/ReaderWriter/ELF/Reader.cpp:109
@@ -106,1 +108,3 @@
+      if (!_elfTargetInfo.allowLinkWithDynamicLibraries())
+        return llvm::make_error_code(llvm::errc::executable_format_error);
       auto f = createELF<DynamicFileCreateELFTraits>(
----------------
Shankar Kalpathi Easwaran wrote:
> Rui Ueyama wrote:
> > We need a better diagnostics here.
> Will change to better error code. 
Couldnt find a better error code. Once we have the diagnostics infrastructure, we should report this properly.


http://llvm-reviews.chandlerc.com/D968



More information about the llvm-commits mailing list