[llvm] r183650 - Avoid warnings about unused parameters that tend to come up a lot when
NAKAMURA Takumi
geek4civic at gmail.com
Tue Jun 11 00:22:45 PDT 2013
Duncan,
It seems -Wdocumentation doesn't like it.
llvm/include/llvm/Support/MathExtras.h:43:12: warning: parameter 'ZB'
not found in the function declaration [Wdocumentation]
llvm/include/llvm/Support/MathExtras.h:112:12: warning: parameter 'ZB'
not found in the function declaration [-Wdocumentation]
Any idea? Simply to eliminate \param ?
...Takumi
2013/6/10 Duncan Sands <baldrick at free.fr>:
> Author: baldrick
> Date: Mon Jun 10 07:09:30 2013
> New Revision: 183650
>
> URL: http://llvm.org/viewvc/llvm-project?rev=183650&view=rev
> Log:
> Avoid warnings about unused parameters that tend to come up a lot when
> building outside projects with a different compiler than that used to build
> LLVM itself (eg switching between gcc and clang).
>
> Modified:
> llvm/trunk/include/llvm/ADT/FoldingSet.h
> llvm/trunk/include/llvm/Support/GetElementPtrTypeIterator.h
> llvm/trunk/include/llvm/Support/MathExtras.h
> llvm/trunk/include/llvm/Support/TargetRegistry.h
> llvm/trunk/include/llvm/Target/TargetLowering.h
> llvm/trunk/include/llvm/Target/TargetMachine.h
>
> Modified: llvm/trunk/include/llvm/ADT/FoldingSet.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/FoldingSet.h?rev=183650&r1=183649&r2=183650&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/ADT/FoldingSet.h (original)
> +++ llvm/trunk/include/llvm/ADT/FoldingSet.h Mon Jun 10 07:09:30 2013
> @@ -352,7 +352,8 @@ template<class T> class FoldingSetBucket
> template<typename T>
> inline bool
> DefaultFoldingSetTrait<T>::Equals(T &X, const FoldingSetNodeID &ID,
> - unsigned IDHash, FoldingSetNodeID &TempID) {
> + unsigned /*IDHash*/,
> + FoldingSetNodeID &TempID) {
> FoldingSetTrait<T>::Profile(X, TempID);
> return TempID == ID;
> }
> @@ -366,7 +367,7 @@ template<typename T, typename Ctx>
> inline bool
> DefaultContextualFoldingSetTrait<T, Ctx>::Equals(T &X,
> const FoldingSetNodeID &ID,
> - unsigned IDHash,
> + unsigned /*IDHash*/,
> FoldingSetNodeID &TempID,
> Ctx Context) {
> ContextualFoldingSetTrait<T, Ctx>::Profile(X, TempID, Context);
>
> Modified: llvm/trunk/include/llvm/Support/GetElementPtrTypeIterator.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/GetElementPtrTypeIterator.h?rev=183650&r1=183649&r2=183650&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/Support/GetElementPtrTypeIterator.h (original)
> +++ llvm/trunk/include/llvm/Support/GetElementPtrTypeIterator.h Mon Jun 10 07:09:30 2013
> @@ -105,7 +105,7 @@ namespace llvm {
>
> template<typename T>
> inline generic_gep_type_iterator<const T *>
> - gep_type_end(Type *Op0, ArrayRef<T> A) {
> + gep_type_end(Type * /*Op0*/, ArrayRef<T> A) {
> return generic_gep_type_iterator<const T *>::end(A.end());
> }
> } // end namespace llvm
>
> Modified: llvm/trunk/include/llvm/Support/MathExtras.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/MathExtras.h?rev=183650&r1=183649&r2=183650&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/Support/MathExtras.h (original)
> +++ llvm/trunk/include/llvm/Support/MathExtras.h Mon Jun 10 07:09:30 2013
> @@ -45,7 +45,7 @@ enum ZeroBehavior {
> template <typename T>
> typename enable_if_c<std::numeric_limits<T>::is_integer &&
> !std::numeric_limits<T>::is_signed, std::size_t>::type
> -countTrailingZeros(T Val, ZeroBehavior ZB = ZB_Width) {
> +countTrailingZeros(T Val, ZeroBehavior /*ZB*/ = ZB_Width) {
> if (!Val)
> return std::numeric_limits<T>::digits;
> if (Val & 0x1)
> @@ -114,7 +114,7 @@ inline std::size_t countTrailingZeros<ui
> template <typename T>
> typename enable_if_c<std::numeric_limits<T>::is_integer &&
> !std::numeric_limits<T>::is_signed, std::size_t>::type
> -countLeadingZeros(T Val, ZeroBehavior ZB = ZB_Width) {
> +countLeadingZeros(T Val, ZeroBehavior /*ZB*/ = ZB_Width) {
> if (!Val)
> return std::numeric_limits<T>::digits;
>
>
> Modified: llvm/trunk/include/llvm/Support/TargetRegistry.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/TargetRegistry.h?rev=183650&r1=183649&r2=183650&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/Support/TargetRegistry.h (original)
> +++ llvm/trunk/include/llvm/Support/TargetRegistry.h Mon Jun 10 07:09:30 2013
> @@ -891,7 +891,7 @@ namespace llvm {
> TargetRegistry::RegisterMCAsmInfo(T, &Allocator);
> }
> private:
> - static MCAsmInfo *Allocator(const MCRegisterInfo &MRI, StringRef TT) {
> + static MCAsmInfo *Allocator(const MCRegisterInfo &/*MRI*/, StringRef TT) {
> return new MCAsmInfoImpl(TT);
> }
>
> @@ -925,8 +925,9 @@ namespace llvm {
> TargetRegistry::RegisterMCCodeGenInfo(T, &Allocator);
> }
> private:
> - static MCCodeGenInfo *Allocator(StringRef TT, Reloc::Model RM,
> - CodeModel::Model CM, CodeGenOpt::Level OL) {
> + static MCCodeGenInfo *Allocator(StringRef /*TT*/, Reloc::Model /*RM*/,
> + CodeModel::Model /*CM*/,
> + CodeGenOpt::Level /*OL*/) {
> return new MCCodeGenInfoImpl();
> }
> };
> @@ -1025,7 +1026,7 @@ namespace llvm {
> TargetRegistry::RegisterMCRegInfo(T, &Allocator);
> }
> private:
> - static MCRegisterInfo *Allocator(StringRef TT) {
> + static MCRegisterInfo *Allocator(StringRef /*TT*/) {
> return new MCRegisterInfoImpl();
> }
> };
> @@ -1058,8 +1059,8 @@ namespace llvm {
> TargetRegistry::RegisterMCSubtargetInfo(T, &Allocator);
> }
> private:
> - static MCSubtargetInfo *Allocator(StringRef TT, StringRef CPU,
> - StringRef FS) {
> + static MCSubtargetInfo *Allocator(StringRef /*TT*/, StringRef /*CPU*/,
> + StringRef /*FS*/) {
> return new MCSubtargetInfoImpl();
> }
> };
> @@ -1178,10 +1179,10 @@ namespace llvm {
> }
>
> private:
> - static MCCodeEmitter *Allocator(const MCInstrInfo &II,
> - const MCRegisterInfo &MRI,
> - const MCSubtargetInfo &STI,
> - MCContext &Ctx) {
> + static MCCodeEmitter *Allocator(const MCInstrInfo &/*II*/,
> + const MCRegisterInfo &/*MRI*/,
> + const MCSubtargetInfo &/*STI*/,
> + MCContext &/*Ctx*/) {
> return new MCCodeEmitterImpl();
> }
> };
>
> Modified: llvm/trunk/include/llvm/Target/TargetLowering.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetLowering.h?rev=183650&r1=183649&r2=183650&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/Target/TargetLowering.h (original)
> +++ llvm/trunk/include/llvm/Target/TargetLowering.h Mon Jun 10 07:09:30 2013
> @@ -148,7 +148,7 @@ public:
> // Return the pointer type for the given address space, defaults to
> // the pointer type from the data layout.
> // FIXME: The default needs to be removed once all the code is updated.
> - virtual MVT getPointerTy(uint32_t AS = 0) const { return PointerTy; }
> + virtual MVT getPointerTy(uint32_t /*AS*/ = 0) const { return PointerTy; }
> virtual MVT getScalarShiftAmountTy(EVT LHSTy) const;
>
> EVT getShiftAmountTy(EVT LHSTy) const;
> @@ -157,12 +157,14 @@ public:
> /// this target.
> bool isSelectExpensive() const { return SelectIsExpensive; }
>
> - virtual bool isSelectSupported(SelectSupportKind kind) const { return true; }
> + virtual bool isSelectSupported(SelectSupportKind /*kind*/) const {
> + return true;
> + }
>
> /// shouldSplitVectorElementType - Return true if a vector of the given type
> /// should be split (TypeSplitVector) instead of promoted
> /// (TypePromoteInteger) during type legalization.
> - virtual bool shouldSplitVectorElementType(EVT VT) const { return false; }
> + virtual bool shouldSplitVectorElementType(EVT /*VT*/) const { return false; }
>
> /// isIntDivCheap() - Return true if integer divide is usually cheaper than
> /// a sequence of several shifts, adds, and multiplies for this target.
> @@ -694,7 +696,7 @@ public:
> /// replacements don't generate code that causes an alignment error (trap) on
> /// the target machine.
> /// @brief Determine if the target supports unaligned memory accesses.
> - virtual bool allowsUnalignedMemoryAccesses(EVT, bool *Fast = 0) const {
> + virtual bool allowsUnalignedMemoryAccesses(EVT, bool * /*Fast*/ = 0) const {
> return false;
> }
>
> @@ -724,9 +726,7 @@ public:
> /// targets without SSE2 f64 load / store are done with fldl / fstpl which
> /// also does type conversion. Note the specified type doesn't have to be
> /// legal as the hook is used before type legalization.
> - virtual bool isSafeMemOpType(MVT VT) const {
> - return true;
> - }
> + virtual bool isSafeMemOpType(MVT /*VT*/) const { return true; }
>
> /// usesUnderscoreSetJmp - Determine if we should use _setjmp or setjmp
> /// to implement llvm.setjmp.
> @@ -1110,9 +1110,9 @@ public:
> /// much computation as possible to be done in the address mode for that
> /// operand. This hook lets targets also pass back when this should be done
> /// on intrinsics which load/store.
> - virtual bool GetAddrModeArguments(IntrinsicInst *I,
> - SmallVectorImpl<Value*> &Ops,
> - Type *&AccessTy) const {
> + virtual bool GetAddrModeArguments(IntrinsicInst * /*I*/,
> + SmallVectorImpl<Value*> &/*Ops*/,
> + Type *&/*AccessTy*/) const {
> return false;
> }
>
> @@ -2031,7 +2031,7 @@ public:
> /// tail call.
> /// This is used to determine whether it is possible
> /// to codegen a libcall as tail call at legalization time.
> - virtual bool isUsedByReturnOnly(SDNode *, SDValue &Chain) const {
> + virtual bool isUsedByReturnOnly(SDNode *, SDValue &/*Chain*/) const {
> return false;
> }
>
>
> Modified: llvm/trunk/include/llvm/Target/TargetMachine.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetMachine.h?rev=183650&r1=183649&r2=183650&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/Target/TargetMachine.h (original)
> +++ llvm/trunk/include/llvm/Target/TargetMachine.h Mon Jun 10 07:09:30 2013
> @@ -252,8 +252,8 @@ public:
> formatted_raw_ostream &,
> CodeGenFileType,
> bool /*DisableVerify*/ = true,
> - AnalysisID StartAfter = 0,
> - AnalysisID StopAfter = 0) {
> + AnalysisID /*StartAfter*/ = 0,
> + AnalysisID /*StopAfter*/ = 0) {
> return true;
> }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list