[polly] r183025 - Test that independent block pass does not transform induction variables

Sebastian Pop spop at codeaurora.org
Mon Jun 10 11:21:52 PDT 2013


> +    Loop *L = LI->getLoopFor(entry);
> +
> +    if (L){

Please add a space between ){

Note that here you are testing for L not NULL...

> +      if (!L->isLoopSimplifyForm())
> +        INVALID(SimpleLoop, "Loop not in simplify form is invalid!");
> +
> +      for (pred_iterator PI = pred_begin(entry), PE = pred_end(entry); PI != PE;
> +           ++PI) {
> +        // Region entering edges come from the same loop but outside the region
> +        // are not allowed.
> +        if (L && L->contains(*PI) && !R.contains(*PI))

... and here you are testing whether L is not NULL again: please
remove this check here, as this is inside a loop.


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation



More information about the llvm-commits mailing list