[PATCH] ARM: Enforce decoding rules for VLD#

Tim Northover t.p.northover at gmail.com
Mon Jun 10 09:04:03 PDT 2013


Hi Amaury,

Sorry for not replying before the weekend.

> I updated the patch, VLDn and VSTn now share the same decoding checker
> methods.

That looks fine, I think.

> What would you say about having decoders in the same fashion as
> DecodeVLD3DupInstruction() for these instructions instead of the huge
> DecodeV{ST,LD}Instruction()?

Hmm. I wouldn't necessarily object, but I suspect it's going to be
ugly whichever way we do it. You can't even really split off the
addressing-modes into a separate function since the writeback has to
be added first, but the other operands at the end.

Tim.



More information about the llvm-commits mailing list