[PATCH] ARM: ISB options other than SY are reserved

[Amaury de la Vieuville]

Thanks Renato, r183656 & r183656!

Amaury

On Mon, Jun 10, 2013 at 2:50 PM, Renato Golin <renato.golin at linaro.org> wrote:
> Hi Amaury,
>
> Sorry for the delay, I think the patch looks good overall. The only nit-pick
> I have is:
>
> +  } else if (Tok.is(AsmToken::Hash) ||
> +             Tok.is(AsmToken::Dollar) ||
> +             Tok.is(AsmToken::Integer)) {
> +    if (Parser.getTok().isNot(AsmToken::Integer))
> +      Parser.Lex(); // Eat the '#'.
>
> The comment is misleading, should be "eat # and $" or something like that.
>
> Other than that, I'm happy with it.
>
> cheers,
> --renato
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>